Your code returned 'rock wins' instead of 'undefined' when the inputs are scissors and paper


#1


https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#

Your code returned 'rock wins' instead of 'undefined' when the inputs are scissors and paper. No idea why and cant find a solution in similar topics??


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2){
    if(choice1 === choice2){
        return "The result is a tie!";
    }else if(choice1 === "rock"){
        if(choice2 === "scissors"){
            return "rock wins"
        }else{
            return "paper wins";
        }
    }else if(choice1 === "paper"){
        if(choice2 === "rock"){
            return "paper wins";
        }else{
            return "scissors wins";
        }
    }else if(choice1 = "scissors"){
        if(choice2 = "rock"){
            return "rock wins";
        }else{
            return "scissors wins!";
        }
    }
}
compare(userChoice, computerChoice);


#2

Do you at least agree that it should not return that rock wins in that scenario? That gives you something to debug.


#3

When I came back to re-read with fresh eyes I immediately saw my mistake..


#4

what was the soultion? i have the same problem :frowning: @slash1406


#5

return "scissors wins";

:smiley: