Why are these two functions working differently

I am working on the mini linter exercise. Specifically step 5: https://www.codecademy.com/courses/introduction-to-javascript/projects/mini-linter

let sentences = 0;

storyWords.forEach((word) => {
if(word.includes(’.’ || ‘!’)) {
sentences+=1;
}
})

let sentencess = 0;
storyWords.forEach(word => {
if (word[word.length-1] === ‘.’ || word[word.length-1] === ‘!’) {
sentencess+=1;
}
});

I wrote the first forEach on my own, and I checked the hint and this second one is what was suggested in the exercise. My first forEach loop iterates to 9 and the second one iterates to 12. There are 12 sentences in the paragraph I am iterating through. What the heck am I doing wrong??? These forEach loops look to me like they should be doing the exact same thing but clearly they’re not and I can’t see the difference. Please help.

What code are you using to get storyWords? Is it an array? Also, could you post the sentences, please?


It seems .includes() does not accept boolean types. So, in your case, the

is only checking for sentences ending in .

1 Like

Hey there, thanks for your reply. Right you are, after a bit more tinkering I discovered if(word.includes(’.’ || ‘!’)) does not accept boolean types and I had to write it like this:

if (word.includes(’.’) || word.includes(’!’)) for it to work the way I was writing it. I’ll post the full code below.

let story = ‘Last weekend, I took literally the most beautiful bike ride of my life. The route is called “The 9W to Nyack” and it actually stretches all the way from Riverside Park in Manhattan to South Nyack, New Jersey. It’s really an adventure from beginning to end! It is a 48 mile loop and it basically took me an entire day. I stopped at Riverbank State Park to take some extremely artsy photos. It was a short stop, though, because I had a really long way left to go. After a quick photo op at the very popular Little Red Lighthouse, I began my trek across the George Washington Bridge into New Jersey. The GW is actually very long - 4,760 feet! I was already very tired by the time I got to the other side. An hour later, I reached Greenbrook Nature Sanctuary, an extremely beautiful park along the coast of the Hudson. Something that was very surprising to me was that near the end of the route you actually cross back into New York! At this point, you are very close to the end.’;

const storyWords = story.split(’ ')
console.log(storyWords.length)

let overusedWords = [‘really’, ‘very’, ‘basically’];

let unnecessaryWords = [‘extremely’, ‘literally’, ‘actually’ ];

const betterWords = storyWords.filter((word) => {
if(unnecessaryWords.includes(word)){
return false;
} else {
return true;
};
});

const numberOf = storyWords.filter((word) => {
if(overusedWords.includes(word)) {
return true;
} else {
return false;
};
});

console.log(numberOf.length)

let sentences = 0;

// original confusing gotcha waiting to hear back a response to my question on
// storyWords.forEach((word) => {
// if (word.includes(’!’ || ‘.’)) {
// sentences+=1;
// }
// })

// written like above but works correctly
storyWords.forEach((word) => {
if (word.includes(’.’) || word.includes(’!’)) {
sentences+=1;
}
})

console.log(sentences);

2 Likes