Whats wrong with my guesses?


#1

I arrived to the Test Run. Bevor i can input something my Code prints out the ship_row and the ship_col. Then in put in the
numbers that i get printed and still my Code says "You missed my Battleship!". Can someone see the error in my code?

Thank you!

https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/5?curriculum_id=4f89dab3d788890003000096

Code:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

print ship_row

print ship_col

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))


# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
print_board(board)

if guess_row not in range(5) or \
    guess_col not in range(5):
        print "Oops, that's not even in the ocean."
elif board[guess_row][guess_col] == x:
    print "You guessed that one already."
else:
    print "You missed my battleship!"

#2

you already have a you missed my battle ship pretty early:

else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"

i would first check if the shot is even in the ocean, or not already guessed:

if guess_row not in range(5) or \
    guess_col not in range(5):
        print "Oops, that's not even in the ocean."
elif board[guess_row][guess_col] == x:
    print "You guessed that one already."

you have you missed my battle ship twice


#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.