What's wrong with my code?


#1


Hi Guys,
I need help finding out what's wrong with my code. Everytime I run it, it seems to give the correct value, but I always get an error message.


Here's the link to the exercise:
https://www.codecademy.com/en/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


And this is the error message
Oops, try again. Your code returned 'paper wins' instead of 'undefined' when the inputs are scissors and paper

And here's my code:


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function (choice1, choice2) {
    if (choice1 === choice2) {
        return "The result is a tie!";
    }
    else if (choice1 === "rock") {
        if (choice2 === "scissors") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }
    else if (choice1 === "paper") {
        if (choice2 === "rock") {
            return "paper wins";    
        } else {
            return "scissors win";    
        }
    }
    else if (choice1 === "scissors") {
        if (choice2 === "rock") {
            return "rock wins";    
        } else {
            return "paper wins";    
        }
    }
};

console.log (compare(userChoice, computerChoice))


#2

else if (choice1 === "scissors") {
        if (choice2 === "rock") {
            return "rock wins";    
        } else {
            return "paper wins";    
        }
    }

who will win if inputs are scissors and paper ?


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.