What's wrong with it? It says choice1 isn't defined


#1



var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare= function(choice1, choice2){
if( choice1 == choice2){
    return "The result is a tie!";
}
else if( choice1 === "rock"){
    if(choice2 === "scissors"){
        return "rock wins";
    }
    }
  else if( choice1 === "paper"){
    if(choice2 === "rock"){
        return "paper wins";
    }
    }  
else if( choice1 === "scissors"){
    if(choice2=== "rock"){
        return "rock wins";
    }
}
}
compare(choice1,choice2);


#2

@classicadi.bhardwaj5,
Please have a look at your build of the IF ELSE-IF construct
and how to execute the compare function....

Please read
http://www.codecademy.com/forum_questions/559dcb4be39efe550f00006b
and concentrate on:

  • the creation of the compare function
  • the truth-table
  • the build of the IF ELSE-IF statement structure as part of the compare FUNCTION-BODY
  • the execution of the compare function (keeping in mind that the return statement is used )

#3

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare= function(Choice1,Choice2){
if( choice1 == choice2){
return "The result is a tie!";
}
else if( choice1 === "rock"){
if(choice2 === "scissors"){
return "rock wins";
}
else{
return "paper wins";
}
}
else if( choice1 === "paper"){
if(choice2 === "rock"){
return "paper wins";
}
else{
return "scissors wins";
}
}
else if( choice1 === "scissors"){
if(choice2=== "paper"){
return "scissors wins";
}
else{
return "rock wins";
}
}
}
compare(Choice1,Choice2);


#4

Can you tell me what is wrong now?


#5

@classicadi.bhardwaj5,

the FUNCTION talk

var myFunc = function( param1, param2) {
       //Begin of  anonymous FUNCTION-BODY
       //VARIABLE -myFunc- has an -anonymous function- assigned
       //this -anonymous function- has 2 PARAMETERS param1 and param2
       //param1 and param2 PARAMETERS are used 
       //as -local- VARIABLES throughout the FUNCTION-BODY

      console.log( param1 + " and " + param2 ) ;

      //End of anonymous FUNCTION-BODY
};

If you want to call/execute the anonymous function
you will have to add a pair of parentheses to the variable myFunc
like
myFunc();
As the anonymous function was defined
as having 2 parameters
you have to provide 2 arguments
in our case 2 string VALUES "Alena" and "Lauren"
like
myFunc("Alena","Lauren");

some quotes from the outer-world:

**argument is the value/variable/reference being passed in,
parameter is the receiving variable used within the function/block**

OR

**"parameters" are called "formal parameters",
while "arguments" are called "actual parameters".**

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

function with 1 parameter using return-statement

var myFunction = function( param1 ) {
       //Begin of FUNCTION-BODY
       //myFunction =function= has 1 PARAMETER param1
       //this param1 PARAMETER is used as a -local- VARIABLE
       //throughout the FUNCTION-BODY

      return param1;

      //End of FUNCTION-BODY
      };

you have defined a myFunction function
which takes 1 parameter param1
this param1 parameter is used
as a variable throughout the FUNCTION-BODY.

If you want to call/execute this myFunction function
and this myFunction function was defined
as having 1 parameter param1
you will have to provide 1 argument
in our case a "number VALUE" 4
myFunction( 4 );

some quotes from the outer-world:

**argument is the value/variable/reference being passed in,
parameter is the receiving variable used within the function/block**

OR

**"parameters" are called "formal parameters",
while "arguments" are called "actual parameters".**

============================================

As you are using the return-statement in your myFunction function
you will only get a return-value no-display.
You can however capture this return-value in a variable
and then use the console.log()-method to do a display.

var theResult = myFunction( 4 );
console.log( theResult );

OR directly

console.log( myFunction( 4 ) );

#6

Is anything wrong with the code or is it just the function error that ain't allowing me to proceed?
kindly modify my code so that i can understand well


#7

@classicadi.bhardwaj5,
You should call the compare()
providing 2 arguments userChoice and computerChoice
that is why i provided the function talk
so you understand what an argument is.....

Have a read through
https://discuss.codecademy.com/t/whats-wrong-with-it-it-says-choice1-isnt-defined/36852/2?u=leonhard.wettengmx.n


#8

how can I call a function with different arguments when I have already defined
var compare= function(choice1, choice2){


#9

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
}
var compare= function(Choice1,Choice2){
if( choice1 == choice2){
return "The result is a tie!";
}
else if( choice1 === "rock"){
if(choice2 === "scissors"){
return "rock wins";
}
else{
return "paper wins";
}
}
else if( choice1 === "paper"){
if(choice2 === "rock"){
return "paper wins";
}
else{
if(choice2 === "scissors") {
return "scissors wins";
}
}
}
else if( choice1 === "scissors"){
if(choice2=== "rock"){
return "rock wins";
}
else{
if(choice2 === "paper"){
return "scissors wins";
}
}
}
}
console.log("User Choice: " + userChoice);
console.log("Computer Choice: " + computerChoice);
compare(userChoice,computerChoice);

Still gives a reference error


#10

@classicadi.bhardwaj5,
Read the function talk article.....
take a break
read it again....