What is wrong with my code ? that i cant see


#1

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function (choice1, choice2) {
    if (choice1 === choice2) {
        return "The result is a tie!";
    }   
   else if (choice1 === "rock") {
    if (choice2 === "scissors") {
        return "rock wins";
    }
    else { 
        return "paper wins";
    }
   }
    else if (choice1 === "paper") {
    if (choice2 === "rock") {
        return "paper wins";
    }
    }
    else { 
        return "scissors wins";
    }
}
    else if (choice1 === "scissors") {
        if (choice2 === "paper") {
            return === "scissors wins"
        }
    }
        else { 
            return "rock wins"
        }
};
var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
console.log(computerChoice);
if (computerChoice <= 0.33) 
{
    computerChoice = "rock";
} 
else if (computerChoice >= 0,67) 
{
    computerChoice = "paper";
} 
else 
{
    computerChoice = "scissors";
}
console.log(computerChoice);


#2

That's one issue. It's just return "scissors wins"

You also set computerChoice twice in the code. Once at the top, and once at the bottom. You don't need to.

According to what the the error say, you have an extra else somewhere. When everything isn't neatly spaced, it makes it much harder to find issues.

If you space stuff out like this, it should make it much easier to find stuff like that.

var compare = function (choice1, choice2){
    if (choice1 === choice2){
        return "The result is a tie!";
    }else if(choice1 === "rock"){
        if(choice2 === "scissors"){
            return "rock wins"
        }
        else
        {
            return "paper wins"
        }
    }else if(choice1 === "paper"){
        if(choice2 === "rock"){
            return "paper wins"
        }
        else
        {
            return "scissors wins"
        }
    }else if(choice1 === "scissors"){
        if(choice2 === "rock"){
            return "rock wins"
        }
        else
        {
            return "scissors wins"
        }
    }
}

#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.