What if choice1 is scissors?


#1

What if choice1 is scissors?

Oops, try again. Your code returned 'scissor wins' instead of 'undefined' when the inputs are scissors and paper


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2) {
    if(choice1 === choice2) {
        return "The result is a tie";
    } 
    else if(choice1 === "rock") {
        
        if (choice2 === "scissors") {
            return "rock wins";
        } 
        
        else { 
            return "paper wins";
        }
    }
    else if (choice1 === "paper") {
        
        if (choice2 === "rock") {
            return "paper wins";
        } 
        
        else { 
            return "scissors wins";
        }
    } 
    else if (choice1 === "scissors") {
        
        if (choice2 === "rock") {
            return "rock wins";
        } 
        
        else { 
            return "scissor wins";
        };
    };
}

compare(userChoice, computerChoice)

the game is working, i get results for every outcome but codeacademy still gives me that error... any idea whats wrong?


#2

oh... found my mistake, sorry for bothering


#3

i have the same problem but i don't see the mistake what was it?


#4

I believe he forgot the s in scissor wins in his last else statement:

 else if (choice1 === "scissors") {
        
        if (choice2 === "rock") {
            return "rock wins";
        } 
        
        else { 
            return "scissor wins";
        };

#5

It also didn't look like he had a section for paper and scissors
}}
else if(choice1 === "scissors") {
if(choice2 === "paper") {
return "scissors wins";
}
}
}


#6

His format is a little different but he has all the conditions considered in his function.


#7

True, I am the type that likes to code everything out so it may just be style perference :smiley: Sorry if any confusion happens


#8

Yeah, his format/style threw me off a little because I wrote mine differently.


#9

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.