What if choice1 is scissors


#1

var compare = function(choice1, choice2){
    if(choice1 === choice2) {
 return "The result is a tie";
}

else if (choice1 === "rock") {
    
if (choice2 === "scissors") {
return "rock wins";
}
else {
return "paper wins";
}

}
else if (choice1 === "paper"){
    if (choice2 === "rock"){
        return "paper wins";
    }
    else {
        return "scissors wins";
    }
    }
    else if (choice1 === "scissors"){
        if (choice2 === "rock"){
           return "rock wins";
        }
        else{ 
            return "scissors wins";
        }
    }
}
    compare(computerChoice + userChoice);
    };

#2

You seem to have an additional }; at the end of your code.


#3

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){
    if(choice1 === choice2) {
 return "The result is a tie";
}

else if (choice1 === "rock") {
    
if (choice2 === "scissors") {
return "rock wins";
}
else {
return "paper wins";
}

}
else if (choice1 === "paper"){
    if (choice2 === "rock"){
        return "paper wins";
    }
    else {
        return "scissors wins";
    }
    }
    else if (choice1 === "scissors"){
        if (choice2 === "rock"){
           return "rock wins";
        }
        else{ 
            return "scissors wins";
        }
    }
}
  compare(computerChoice,userChoice);

still have prblems. says I din't call the arguments?


#4

Seems to be ok maybe switch the order of your arguments userChoice, computerChoice. Also indenting your code, like you did in the last else if, makes it easier to read. Also try to refresh your page, this reloads the js and often helps if there is no bug in the code.