What if choice1 is scissors? What am I doing wrong?


#1

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function (choice1, choice2) {;
if (choice1 === choice2) {;
return "The result is a tie!";
}
else if(choice1 === "rock") {
if(choice2 === "scissors") {
return "rock wins";
}

else {
return "paper wins";
}
else if(choice1 === "paper") {
if(choice2 === "rock") {
return "paper wins";
}
else {
return "scissors wins";
}

else if(choice1 === "scissors") {
if(choice2 === "rock") {
return "rock wins";
}
else {
return "scissors wins";
}
};
//syntax error: Unexpected token


#2

Hello @kartavicious,

First: Check this post - refering to your indent style

Second: You got a few mistakes in your code.
Check my code below and try to understand them (your mistakes):
Here your corrected, and better formatted code:

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();

if (computerChoice < 0.34) 
{
    computerChoice = "rock";
} 
else if(computerChoice <= 0.67) 
{
    computerChoice = "paper";
} 
else 
{
    computerChoice = "scissors";
} 

console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2) 
{
    if (choice1 === choice2) 
    {
        return "The result is a tie!";
    }
    else if (choice1 === "rock") 
    {
        if (choice2 === "scissors") 
        {
            return "rock wins";
        }
        else {
            return "paper wins";
        }
    }
    else if (choice1 === "paper") 
    {
        if (choice2 === "rock") 
        {
            return "paper wins";
        }
        else 
        {
            return "scissors wins";
        } 
    } 
    else 
    {
        if (choice2 === "paper") 
        {
            return "scissors wins";
        }
        else 
        {
            return "rock wins";
        }
    } 
}

compare(userChoice, computerChoice);

Hope I could help you :slight_smile:


Rock, Paper, Scissors part 4/9 "Computer Choice: Part 2"
#3

Thank you, I see what I did now. I also reformatted to make it look cleaner. I never realized that could be such an issue but it really does make troubleshooting easier.