To Your Battle Stations!


I made a code that work pretty fine:

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print "You have 4 guesses."

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

for turn in range(4):
    guess_row = int(raw_input ("Guess Row:"))
    guess_col = int(raw_input ("Guess Col:"))

    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
            print "End of turn", turn +1
        if turn == 3:
            print "Game Over"

I have one question though.

Is it possible to somehow change the code so that the raw input of the user is equal to the index?
I mean, whenever you type f.e. "4", it marks 5th row/column, which is confusing. Any ideas how to fix that?


what you could do is this:

if (guess_row < 1 or guess_row > 5) or (guess_col < 1 or guess_col > 5):
   guess_row -= 1
   guess_col - = 1

this way, the user can enter 1 till 5, and then you subtract one to cover the gap between array (zero index based) and human count (one index based)


You could put a -1 after it:
guess_row = int(raw_input("Guess Row:") - 1)

Similar to the random number generator:
return randint(0, len(board) - 1)


This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.