Test Run


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)


def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print("Congratulations! You sank my battleship!")
if guess_row not in range(5) or guess_col not in range(5):   "<--- line 31"
        print "Oops that's not even in the ocean."
elif (board[guess_row][guess_col] == "X"):
    print("You guessed that one already.")

    board[guess_row][guess_col] = "X"
    print('You missed my battleship')


Hello, again, I'd like to thank all in advance..... When I guess correctly it prints both the "Congratulations" string and the "You missed my battleship" string, can't seem to figure out why.

Also, in line 31 i had to change "if guess_row != range(5) etc" to what is displayed on the current screen, just curious why exactly?

If there is any other suggestions on improvements to the code, I would appreciate your input, thank's again!


solved, if where and elif should be