Test Run



For some reason my code is passed off as being correct, despite the fact that:
a.) It will output an error when NO input is entered. (Error message: Traceback (most recent call last):
** File "python", line 22, in **
ValueError: invalid literal for int() with base 10: '')
b.) When I take a guess within the range, it will output the message "Oops, that's not even in the ocean." (this happens when I miss the battleship).

I'm taking it that my code's order of the if-else-statements is wrong. Which one is the correct order? And how can I make sure that my code will run even if no input is entered?

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)


def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_row == ship_col:
    print "Congratulations! You sank my battleship!"
    if guess_row != range(5) or guess_col != range(5):
        print "Oops, that's not even in the ocean."
    elif board[guess_row][guess_col] == 'X':
        print "You guessed that one already."
        print "You missed my battleship!"
        board[guess_row][guess_col] = 'X'


the exercise assumes valid input, the problem is that if you supply invalid input to int(), you will get a value error. You can fix this, simply ask for input, then check if input is not empty, if so, convert to integer

looking at your condition:

if guess_row != range(5) or guess_col != range(5):

i see the problem, guess_row contains an integer and range produces a list. integer != list is true, so it will produces not in ocean


This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.