# Test Run problem - Battleship

#1

I passed all the lectures but if I put some numbers in for guess_row and col which are in the range of 5. My code prints "Oops, that is not even in the ocean!" every time. I guess it is just a small misstake, but I can't find it. Thanks for helping

``````from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

if guess_row == ship_row and guess_col == ship_col:
print("Congratulations! You sank my battleship!")
else:
if guess_row is not range(5) or \
guess_col is not range(5):
print("Oops, that\'s not even in the ocean.")
elif board[guess_row][guess_col] =="X":
else:
print("You missed my battleship!")
board[guess_row][guess_col]="X"
print print_board(board)``````

Edit: for everyone with the same problem i just used " if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4): " this worked out

#2

to check if something is present in a list or string we can use `in` keyword

to check if something is not present in a list or string we can use `not in`

you use `is` keyword, which is not right

#3

Look close at the: if geuss_row is not range(5) or... statement.

#4

Thank you guys! Works

#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.