Syntax error: What if choice1 is scissors


#1

Hi,

I am having trouble spotting my error, I've spent the past couple of days trying to figure it out for myself, can someone help me please?

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function (choice1, choice2) {
if (choice1 === choice2) {
return "The result is a tie!";
} else if
(choice1 === "rock") {
if (choice2 === "scissors") {
return "rock wins";
}
else {
return "paper wins";
}
}

//all working up to here
else if (choice1 === "paper")
      { 
          if (choice2 === 'rock') {
        return ("paper wins");
      }
        else 
        {
            return ("scissors wins");
        }   

        else if (choice1 === "scissors")
        {
      if (choice2 === "rock")
        return "rock wins"
        }
        else {return "scissors wins";
        }

};
console.log(compare(userChoice,computerChoice));

Many thanks


#2

Here it is. you were missing a couple braces

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {computerChoice = "rock";} 
else if(computerChoice <= 0.67) {computerChoice = "paper";} 
else {computerChoice = "scissors";} 

console.log("Computer: " + computerChoice);

var compare = function (choice1, choice2) {
                if (choice1 === choice2) {return "The result is a tie!";} 
                else if (choice1 === "rock") {
                    if (choice2 === "scissors") {return "rock wins";}
                    else {return "paper wins";}
                }

                //all working up to here
                else if (choice1 === "paper"){ 
                    if (choice2 === 'rock') {return ("paper wins");}
                    else {return ("scissors wins");}  
                }

                else if (choice1 === "scissors"){
                    if (choice2 === "rock"){return "rock wins";}
                    else {return "scissors wins";}
                }
            };
console.log(compare(userChoice,computerChoice));

#3

Thank you very much, worked great!