Stuck on "Build rock, paper, scissors"


#1

Not sure what's wrong here, anyone have any ideas?

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2)
{
if(choice1 === choice2)
{
return"The result is a tie!";
}
else if(choice1 === "rock") {
if(choice2 === "scissors")
{ return "rock wins";
}
else
{ return "paper wins";
}
}
}

else if(choice1 === "paper")
{
if(choice2 === "rock") {return"paper wins";}
else{return"scissors wins";}

}
else if(choice1 === "scissors")
{
if(choice2 === "rock"){return"rock wins";}
else{return"scissors wins";}
};
compare(userChoice, computerChoice);


#2

Hi if you keep you code indent like that (SO that you could read you code well and see the error )

var compare = function(choice1, choice2){
    if (condition) {
          #do something
    }
    else if (condition) {
        if (condition) {
          #do something
        }
        else {
          #do something
        }
    }

    else if (condition) {
        if (condition) {
          #do something
        }
        else {
          #do something
       }
    }
};

and to format your code you can ead this post


#3

In the console log it should be without the + sign like so:

console.log("Computer computerChoice");

#4

Hi @desiigner if he put it without the +

console.log("Computer computerChoice");

it will print

Computer computerChoice

but with the +

console.log("Computer: " + computerChoice);

it will print

Computer: rock
or
Computer: paper
or
Computer: scissors

it will depent of the computerChoice SO its better if he keep what he did in his code.


#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.