Stuck on Bad Aim!


#1

Hi everyone!

My name's Mark, I'm relatively new to the site, only recently started coding.

I am stuck on the Bad Aim portion of Battleship.

Up to this point, my code seems to handle all the contingencies just fine:
Hits and misses generate the right responses, and when guesses are out of range/off the board, it prints "Oops, that's not even in the ocean!"

Yet, I get an error message saying "Make sure you print "Oops, that's not even in the ocean." if the user guesses a row or column that is off the board."

Please help!! Where have I gone wrong?

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

if guess_row == ship_row and  guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
    print board[guess_row][guess_col]

else:
    if guess_row in range(5) and guess_col in range(5):
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"

    if guess_row not in range(5) or \
    guess_col not in range(5):
        print "Oops, that's not even in the ocean!" 

print_board(board)

#2

Change the exclamation point in "Oops, that's not even in the ocean!" to a period. Whenever I get an error and I think that my code is correct I check to make sure the strings match the instructions exactly. These errors are kind of annoying, sorry :smiley:


#3

OMG, you hit it on the head! That is super annoying! Oh well, in the process of trying to figure it out, I must have learned 10 different ways to set up those conditionals!