Stuck in step 8 What if choice1 is scissors?


#1


https://www.codecademy.com/en/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#


Hi guys, i'm having a hard time with this project, and to be honest i don't know where i'm wrong as every possible combination is already covered by code, i keep getting this message:

"Oops, try again. Your code returned 'paper wins' instead of 'undefined' when the inputs are scissors and rock"


Replace this line with your code. 
var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){
    choice1=userChoice;
    choice2=computerChoice;
    if (choice1 === choice2){
        return "The result is a tie!";
    }
    else if(choice1 === "rock"){
            if(choice2 === "scissors"){
                return "rock wins";
            }
            else {
                return "paper wins";
            }
        }
    else if (choice1 === "paper"){
        if (choice2 === "rock"){
            return "paper wins";
        }
        else {
            return "scissors wins";
        }
    }
    else if (choice1 === "scissors"){
        if (choice2 === "rock"){
            return "rock wins";
        }
        else {
            return "scissors wins";
        }
    }
};
compare(userChoice,computerChoice);


#2

where have you called the compare function?

var compare = function(choice1, choice2){

you have that function but you have not called it yet!

you should call it here:

 if(choice1 === "scissors") {
        if(choice2 === "rock") {
            return "rock wins";
        }else{
            return "scissors wins";
        }
    }    
}

console.log(compare(userChoice, computerChoice));

Hope this helps

Steven


#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.