Stuck in 12 bad aim


#1



https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096#


error message says "List index out of range"


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = 'X'
    print_board(board)
if guess_row not in range(5) or guess_col not in range(5):
        print ("Oops,that's not even in the ocean.")
else:
    incorrect = 0
    for X in board:
        incorrect += 1


#2

output is

O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
Guess Row: 10
Guess Col: 10
2
0
You missed my battleship!
Traceback (most recent call last):
  File "python", line 33, in <module>
IndexError: list index out of range

#3

If a value of 5 or greater is inputed, it will be out of the range of the list. Test for the range before other checks (apart from winning).

if ___:
    # you win
elif ___ not in range ___:
    # not in the ocean
elif ___ guessed already
    # guessed already
else:
    # missed battleship

#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.