Still struggling with this exercise


#1

Still struggling with this exercise. Any help would be greatly appreciated. Here is my code, focusing on else if statement for "scissors":
var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function(choice1, choice2) {
if(choice1 === choice2) {
return "The result is a tie!";
}
else if (choice1 === "rock") {
if (choice2 === "scissors") {
return "rock wins";
}
else {
return "paper wins";
}
}
else if (choice1 === "paper") {
if (choice2 === "rock") {
return "paper wins";
} else {
return "scissors wins";
}
}
}
else if(choice1 === "scissors") {
if(choice2 === "paper") {
return "scissors wins";
}
else {
return "rock wins";
}
}
};
console.log (compare(userChoice, computerChoice));


8. What if choice1is scissors? Arguments mistake
#2

@codejumper43464,
With your code
like

var compare = function(choice1, choice2) {
  if(choice1 === choice2) {
     return "The result is a tie!";
  }

  else if (choice1 === "rock") {
    if (choice2 === "scissors") {
       return "rock wins";
    }
    else {
       return "paper wins";
    }
  }

  else if (choice1 === "paper") { 
    if (choice2 === "rock") {
      return "paper wins"; 
    } else {
      return "scissors wins";
    }
  }

}   //<===== here you close the =compare= FUNCTION

you are closing the compare function to early
causing the following code

  else if(choice1 === "scissors") {
    if(choice2 === "paper") {
      return "scissors wins";
    }
    else {
      return "rock wins";
    }
  }
}; <<== trying to close the function again ???

not to be seen as being part of the compare function !!!!


#3

Thank you very much for the prompt response and advice. @wizmarco helped me out with my problem. I truly appreciate all the help. I'm starting to get a lot better with Javascript.

Matt