Solved~~~


#1


https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/1/3?curriculum_id=4f89dab3d788890003000096

Sometimes gives this error: Traceback (most recent call last):
File "python", line 20, in
NameError: name 'ship_row' is not defined. Other times it works but always prints 'You missed my battleship' twice regardless of the answer.


```
from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

print ship_row
print ship_col

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print 'You missed my battleship!'
    board[guess_row][guess_col] = 'X'
    if guess_col not in range(5) or guess_row not in \
    range(5):
        print 'Oops, that\'s not even in the ocean.'
    else:
         print 'You missed my battleship!'
    board[guess_row][guess_col] = 'X'


#2

Then you'd go to that line and consider where in the code that has run so far it would have been defined


#3

Would the 'print ship_row and col' need to go after 'ship_row = random_row(board) and ship_col = random_col(board)'?


#4

You tell me.

My cat is the color I mentioned earlier.
Black.


#5

Don't ask, try it :slight_smile:


#6

Yeah, thanks that works now but I still get this error when the answer is not in range:
Traceback (most recent call last):
File "python", line 33, in
IndexError: list index out of range


#7

I'm still getting 'You missed my battleship' every time I enter an answer, right or wrong.

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"

else:
    print 'You missed my battleship!'
    board[guess_row][guess_col] = 'X'
    print_board(board)
    if guess_col not in range(5) or guess_row not in \
    range(5):
        print 'Oops, that\'s not even in the ocean.'
    else:
        board[guess_row][guess_col] = 'X'

#8

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.