# [SOLVED] 12/19 Bad Aim! - Something wrong with if statements

#1

There is my code:

``````from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

guess_row = int(raw_input("Guess Row: "))
guess_col = int(raw_input("Guess Col: "))

if guess_row == ship_row and guess_col == guess_col:
print "Congratulations! You sank my battleship!"
else:
if guess_row not in range(5) or guess_col not in range(5):
print "Oops, that's not even in the ocean."
else:
print "You missed my battleship!"
board[guess_row][guess_col] = "X"
print_board(board)
``````

Something seems going wrong in the first if statement.
The code gives the expected output with almost every kind of input but, if i get the value of `guess_row` to be equal to `ship_row` and then `guess_col` to be a different value than `ship_col` (obviously inside the acceptable range) i get `"Congratulations! You sank my battleship!"` while i should be getting `"You missed my battleship!"`

#2

``````if guess_row == ship_row and guess_col == guess_col:
``````

`guess_col` will always equal `guess_col`, they are the same variable thus the same value

#3

My fault, missed it. Thank you very much!

#4

no problem, that happens. That is what the forum is for

Youâ€™re welcome

#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.