# Shouldn't the "X" be one spot in an item rather than a whole row?

#1

Battleship, however everything is passing and continuing.

I am expecting it to be single characters and not entire rows, am I expecting to much to early, or missed defining something?

``````from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

print ship_row
print ship_col

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if (guess_row == ship_row and guess_col == ship_col):
print "Congratulations! You sank my battleship!"
else:
if guess_row not in range(5) or \
guess_col not in range(5):
print "Oops, that's not even in the ocean."
else:
print "You missed my battleship!"
board[guess_row] = "X"
board[guess_col] = "X"
print_board(board).``````

#2

yea, you should have combined the coordinates to a single spot:

``board[guess_row][guess_col] = "X"``

it is a multi dimension list. so you need two indexes to reach the inner list

#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.