School Catalog Project - string instead of number not triggering console log error

lauriemrauch · July 20, 2023, 10:46pm

Howdy!

I know this is something silly, but I need another set of eyes.

Here’s my code so far:

laurierauch/full-stack-engineer/blob/main/school-catalog.js#L18


      
          get name() {
            return this._name;
          }
          get level() {
            return this._level;
          }
          get numberOfStudents() {
            return this._numberOfStudents;
          }
          
          set numberOfStudents(num) {
            if (typeof num !== 'number'){
              this._numberOfStudents = 'That is Not a Number!';
              console.log('Invalid input: numberOfStudents must be set to a Number.');
            } else {
              this._numberOfStudents = num;
            }
          }
          
          quickFacts() {
            console.log(`${this._name} educates ${this._numberOfStudents} students at the ${this._level} school level.`);

This returns:

Lorraine Hansbury educates George students at the primary school level.

It should return:

Lorraine Hansbury educates That is Not a Number! students at the primary school level.

and there should be a log in the console, which there is not.

Why is this conditional not working as expected?

taylorsabbag · July 21, 2023, 2:58am

When you’re defining the numberOfStudents property for the lorraineHansbury primary school object you created, the second parameter is the numberOfStudents, but you set it to ‘George’.

Moreover, you made it so that when the numberOfStudents provided as a parameter is not a number, it sets the numberOfStudents for that object to a number. But you’d probably want to just log an error in such a case.

lauriemrauch · July 21, 2023, 3:09pm

That… was intentional? It should reflect ‘That’s not a number’ when a string, like ‘George’, is added. I was testing to make sure it worked. It does not.

lauriemrauch · July 21, 2023, 4:01pm

Fixed it. Removed the call for the numberOfStudents in the Primary class, and the underscores in the getters for School.
New code here:

github.com

laurierauch/full-stack-engineer/blob/main/school-catalog.js

class School {
  constructor(name,level,numberOfStudents) {
    this._name = name;
    this._level = level;
    this.numberOfStudents = numberOfStudents;
  }

  get name() {
    return this._name;
  }
  get level() {
    return this._level;
  }
  get numberOfStudents() {
    return this.numberOfStudents;
  }

  set numberOfStudents(num) {
    if (typeof num !== 'number'){
      this._numberOfStudents = 'That is Not a Number!';

This file has been truncated. show original