Rock, Paper, Scissors


#1

https://www.codecademy.com/courses/javascript-beginner-en-Bthev-mskY8/1/4?curriculum_id=506324b3a7dffd00020bf661#

I am confused with what to do next. The instructions mention "Call your function and pass in userChoice and computerChoice as your two arguments". I have trouble understanding this.

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare = function (choice1, choice2) {
    if (choice1 === choice2) {
        return "The result is a tie!";
    }
    
    else if (choice1 === "rock") {
       
        if (choice2 === "scissors") {
            return "rock wins";
        } 
        else {
            return "paper wins";
        }
    }
    
    else if (choice1 === "paper") {
        if (choice2 === "rock") {
            return "paper wins";
        }
        else {
            return "scissors wins";
        }    
    }
    
    else if (choice1 === "scissors") {
        if (choice2 === "paper") {
            return "scissors wins";
        }
        else {
            return "rock wins";
        }
    }
};

#2

This is your function,s name so instead of choic1 and choice2 as arguments on the last line of your code they want you to call your function like this
compare(userChoice, computerChoice)


#3

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);
var compare=function(userChoice,computerChoice) {
if(choice1===choice2) {
return "The result is a tie";
}
else if(choice1==="rock")
{ if(choice2==="scissors")
{ return "rock wins"; }
else
{ return "paper wins"; }
}
else if(choice1==="paper") {
if(choice2==="rock")
{ return "paper wins"; }
else
{ return "scissors wins"; }
}
else if(choice1==="scissors") {
if(choice2==="rock")
return "rock wins"; }
else
{ return "scissors wins"; }
}}};
compare(userChoice,computerChoice)

SyntaxError: expected expression, got '}'
I don't know what I'm doing wrong here.


#4

At the end of your compare function, you have 4 closing curly brackets. Why 4?


#5

I figured this out a while ago. I forgot a bracket before my if return, thanks though!


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.