Rock, Paper, or Scissors

websolver58173 · July 16, 2020, 8:32pm

gist.github.com

https://gist.github.com/codecademydev/0bc6419f6fe9747dd6c8d9de0ec3fd0c

rockPaperScissors.js

const getUserChoice = userInput => {
  const getUserChoice =  userInput.toLowerCase();
  if (userInput === 'rock' || userInput === 'paper' || userInput === 'scissors' || userInput === 'bomb') {
  return userInput;
} else {
  console.log('Error!');
}
};
function  getComputerChoice () {
   getComputerChoice = Math.floor(Math.random() * 3);

This file has been truncated. show original

codeneutrino · July 16, 2020, 8:36pm

Hello! Did you want feedback or do you have a specific question?

Some feedback:
The whole code is very well thought out, and correctly implements the instructions. Just one thing, you might want to make the if…else if…else statements here into a switch…case:

if (getComputerChoice === 0) {
   return 'rock';
 } else if (getComputerChoice === 1) {
   return 'papper';
 } else {
   return 'scissors';
 };

One other thing, after closing curly braces }, you don’t need a semicolon (in general). Here is a good article on semicolons in JS.
I hope this helps!

8-bit-gaming · July 16, 2020, 8:48pm

Just a quick edition to @codeneutrino’s feedback:

I believe there is a typo on line 14:

return 'papper';

Other than that it is very nicely written, and everything seems to work perfectly. Great job

system · August 27, 2020, 12:48pm

This topic was automatically closed 41 days after the last reply. New replies are no longer allowed.