Real Win


#1

code is giving error as such syntax error :invalid syntax

after the break statement as else:

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
break
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
    print_board(board)
for turn in range(4):
    print "Turn",turn+1
if turn == 3:
    print "Game Over"

Please verify my problem and rectify.


#2

your break is wrongly indented, break should occur when if condition is true


#3

I see that my if condition is true .....Could you please clarify with my code where is the error


#4

^ i did tell you where code goes wrong?


#5

How do I correct that .....


#6

indent it so its nested inside if clause


#7

for me the same problem. I did indent it to the loop

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sunk my battleship!"
break

it still says:
SyntaxError: 'break' outside loop


#8

i can't tell without your code

please provide your full code so i can help, with just this small section of your code, you are making my job pretty difficult :wink:


#9

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break

for me the same problem. I did indent it to the loop
it still says:
SyntaxError: 'break' outside loop


#10

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sunk my battleship!"
    break  
    
else:
    if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
    print_board(board)
for turn in range(4):
    print "Turn", turn + 1

if turn == 3:
    print "Game Over"

whole code, sry I'm using the comments section for the first time


#11

this hints:

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!

are a pretty big hint?


#12

which for loop? the hint is not clear to me. could you suggest how to put it in a for loop?


#13

you only have one loop:

for turn in range(4):

everything below the comment should be in the loop, currently there is only turn print in the loop


#14

it worked, thank you very much!


#15

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.