Python - Battleship game


#1

https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/1/2?curriculum_id=4f89dab3d788890003000096

So I've been coding on Python for some time now, and I've arrived till the Battleship: Danger, WIll Robinson chapter.

However, here, I appear to get an error if I type numbers greater than 5, in the input.

Here is my code:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    print "You missed my battleship!"
    board[guess_row][guess_col]="X"

There is no error in case I provide numbers lesser than 5 as my inputs.

Further the error I get is:

Traceback (most recent call last):
File "python", line 33, in
IndexError: list index out of range

I would like to know if this is addressed further, or am I doing something wrong here ?

Regards,
Pavan


#2

Check the range right after checking for a win.

Oops! Too soon for that. At this point just be sure your input is 0 to 4. Remember that lists are zero-indexed.


#3

Okay, so I did go forward, and then found that there is an elif statement that I need to add.

I did add, and however, after printing the required statement of guesses being off the board, it still gives me the same error.

Can you please help ?

Here is my code:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) and guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    elif board[guess_row][guess_col] == "X":
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
board[guess_row][guess_col]="X"
print_board(board)

#4

Those lines look like they need to be indented. Will leave it to you.


#5

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.