Program will only print “that’s not even in the ocean” no matter what


#1

my program will only print “that’s not even in the ocean” no matter what you put into the raw_input statements.

this is what my if statement looks like:

if guess_row not in range(5) or
guess_col not in range(5):
print “Oops, that’s not even in the ocean.”

please help


FAQ: Learn Python - Battleship - Play It, Sam
#2

please post your full code


#3

full code:

from random import randint

board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)

print_board(board)

def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should be in your for loop
# don't forget to properly indent!
for turn in range(4):
  print "Turn", turn + 1
  guess_row = raw_input("Guess Row: ")
  guess_col = raw_input("Guess Col: ")

  if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"   
  else:
    if guess_row not in range(5) or \
      guess_col not in range(5):
          print "Oops, that's not even in the  ocean."
    elif board[guess_row][guess_col] == "X":
      print( "You guessed that one already." )
    else:
      print "You missed my battleship!"
      board[guess_row][guess_col] = "X"
    print_board(board)

#4

you prompt the user for input using raw_input, but what data type does raw_input give back?


#5

Can I know what language are you using?


#6

Python version 2.7.10

  • Use raw_input with Python 2.x.
  • Use input with Python 3.x.

Documentation:

The documentation for raw_input contains the answer to @stetim94’s question. This also applies to input in Python 3.x.

Avoid using input with Python 2.x.