Please Review My HTML & CSS Code (Dasmoto’s Arts & Crafts Project)

Hi friends, I just completed the Dasmoto’s Arts & Crafts project.
Visually I got the result I wanted but I want to ensure I’m following the best coding practices.

Please take a look at my HTML and CSS codes below:

HTML

<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="style.css">
  <title>Dasmoto's Arts & Crafts</title>
</head>
<body>
    <h1>Dasmoto's Arts & Crafts</h1>
      <h2 class="brushes">Brushes</h2>
        <img src="hacksaw.jpeg".jpg alt="hacksaw">
        <h4>Hacksaw Brushes</h4>
          <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="new-spec">Starting at $3.00 / brush.</span></p>
    
      <h2 class="frames">Frames</h2>
        <img src="frames.jpeg".jpg alt="frames">
        <h4>Art Frames (assorted)</h4>
          <p>Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs. <span class="new-spec">Starting at $2.00 / frame.</span></p>

      <h2 class="paint">Paint</h2>
        <img src="finnish.jpeg".jpg alt="finnish">
        <h4>Clean Finnish Paint</h4>
          <p>Imported paint from Finland. Over 256 colors available in-store, varying in quantity (1 oz. to 8 oz.). Clean Finnish paint microbinds to canvas, increasing the finish and longevity of any artwork. <span class="new-spec">Starting at $5.00 / tube.</span></p>

</body>
</html>

CSS

body {
    font-family: Helvetica;
}
h1 {
    background-image: url("pattern.jpeg");
    font-size: 100px;
    font-weight: bold;
    color: khaki;
    text-align: center;
}
.brushes, .frames, .paint {
    font-size: 32px;
    front-weight: bold;
    color: white;
}
.brushes {
    background-color: mediumspringgreen;
}
.frames {
    background-color: lightcoral;
}
.paint {
    background-color: skyblue;
}
.new-spec {
    font-weight: bold;
    color: blue;
}

Looks good. The only thing I might suggest (and this could just be the way it got pasted in the post) would be to make sure you put line breaks between your css elements for pure readability sake. Good job and happy coding.

Walt

1 Like

It’s been three days. Do you still want feedback, or have you accepted this as fine enough to move away from?

Hi mtf, sorry I haven’t been very active on this forum. You can leave a review of my code if you are still interested :slight_smile:. I’d really appreciate it.

In the three weeks hence, this project has come up a couple of times in the forums. May we suggest locating and reading those threads for more insight into this project. As it stands, it would be better for you to review your code against those other threads, as well as best practices and document outline. Being at the very early stages it would not be fair to comment any further.

Alright, I’ll check other threads. Thanks for the suggestion.

1 Like

Do check back and keep us alerted to your findings, and further questions. It’s how this is done in a community of interested parties. We all want to know more, and in greater detail. Join the club!

1 Like

For am just starting out