Play It, Sam


#1



I wonder why the loop does not stop while i type the correct answer and it keeps showing "Oops, try again. Did you remember to print out turn + 1 each turn? ". Thank you so mcuh


from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col
# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
            break
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    # Print (turn + 1) here!
        print "Turn+", str(turn+1)
        print_board(board)


#2

I had that problem too. Apparently, it should look like this:

for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    print "Turn", turn + 1
    print_board(board)

Notice how the print lines at the bottom are at the same indentation level as your first if statement.


#3

I don't think it must be in the same indentation level with the "else" statement. The problem with the code is converting the result into a string when it should actually be an integer as defined in the range call above, only with this can the addition can take place.


#4

I'm pretty sure this code never converts anything to a string. Therefore, I can safely say that it is just the indentation thing.


#5

Sorry, I was referring to cloudjumper's code, not yours.


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.