Play It, Sam


#1



https://www.codecademy.com/courses/python-beginner-en-4XuFm/2/1?curriculum_id=4f89dab3d788890003000096
i really dont get why its showing this

Oops, try again. Your code looks a bit off. Check the Hint if you need help! Your code threw the following error: invalid literal for int() with base 10: ''

It looks correct i dont understand why it doesn't work


Replace this line with your code. 
from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
for turn in range(4):
    
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))

    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
            print "Turn",turn + 1
            print_board(board)


#2

There should be a console error (in red text) with traceback information. Please post that error message in its entirely. Thanks.


#3

Traceback (most recent call last):
File "python", line 29, in
ValueError: invalid literal for int() with base 10: ''

sorry about that


#4

Traceback (most recent call last):
File "python", line 29, in
ValueError: invalid literal for int() with base 10: ''


#5

For me that happens when i don't enter any number and just press enter


#6

Correct. The error indicates non-numeric return value from raw_input(). (Line 29 and/or 30 will raise this error if no number is inputted.).

Aside

We can make the code easier to read with two simple changes...

elif guess_row not in range(5) or guess_col not in raange(5):

and,

if ___:

elif ___:

elif ___:

else: ___

No need for extra nesting, as in,

else:
    if ____:

#7

yes that worked thank you so much!!!


#8

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.