Play it, Sam. Strange Error, Help Please?


#1

So here's the issue. I'm not getting any error codes, everything is running fine, but the first time I enter my guess, for example (2, 3), it will guess that for all 4 turns. Here is my code:

from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
for turn in range(4):
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    else:
        if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or
        guess_col > 4):
            print "Oops, that's not even in the ocean."
        elif(board[guess_row][guess_col] == "X"):
            print "You guessed that one already."
        else:
            print "You missed my battleship!"
            board[guess_row][guess_col] = "X"
    print "Turn", turn + 1
    print_board(board)
    if turn == 4:
        print "Game Over"

If someone could let me know the error in my coding, that would be great. Thanks.


#2

@omarbawab6

This HAS to be in your for loop.


#3

I think I know your problem.

In your code you put

guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))
for turn in range(4):
    #Then the rest of your for loop here.

You need to put
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

INSIDE your for loop, like this:

for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    #Then the rest of your for loop here.

I really hope this helps.


#4

That was a great help. Thanks!


#5

That worked. Thanks so much!


#6

No problem. (Also, could you check out the problem I am having right now?)


#7

Sure, I'd be glad too. But seeing as you just answered my question, I don't know if I'm on your level of Python understanding...