Play it, Sam (Code works but game won't end when a guess is right?)


#1



https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/2/1?curriculum_id=4f89dab3d788890003000096


The code works but if, after turn 1, the correct location is guessed...the game continues to prompt the user to enter more guesses until turn 4. How can I make sure the game ends when the correct location is guessed? e.g. there are 4 turns allowed but the user guesses the correct location on turn 2 and the game should end rather than continuing to ask for user input.


Replace this line with your code. 
from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"
print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col
#The above print lines display the ship location
# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
for turn in range(4):
    guess_row = int(raw_input("Guess Row:"))
    guess_col = int(raw_input("Guess Col:"))
    
    if guess_row == ship_row and guess_col == ship_col:
        print "Congratulations! You sunk my battleship!"
    elif (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
        print "Oops, that's not even in the ocean."
    elif(board[guess_row][guess_col] == "X"):
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
    print "Turn", turn + 1
    print_board(board)


#2

Add a break statement after the print out.


#3

Thank you! Such an obvious fix but hindsight is always 20/20 :slight_smile:


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.