"Oops try again" 'Rock wins' instead of 'undefined'


#1

Not sure what I'm missing help, below is the following error message.


Your code returned 'rock wins' instead of 'undefined' when the inputs are scissors and paper


var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){
    if(choice1 === choice2){
        return ("The result is a tie!");
    }
    if (choice1 === "rock"){
        if (choice2 === "scissors"){
            return ("scissors wins");
        }else{
            return ("paper wins");
        }    
    }
    if(choice1 === "paper"){
        if(choice2 === "rock"){
            return ("paper wins"); 
        }else{
            return ("scissors wins");
        }
    }
    if (choice1 === "scissors"){
        if(choice2 === "rock"){}
        return("rock wins");
    }else{
        return("scissors wins");
    }
};

compare(userChoice, computerChoice)


#2

Is this lesson 7? I think this lesson does not expect the last case segment. Comment it out so the function return undefined.


#3

Your exactly right, thank you.


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.