Not again


#1

Can anyone tell me what could be wrong in my code below.

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row not in range(5) or guess_col not in range(5):
   print "Oops,that's not even in the ocean."
elif (board[guess_row][guess_col] == "X")
    print "You guessed that one already."
else:
   if guess_row == ship_row and guess_col == ship_col:
       print "Congratulations! You sank my battleship!"
   else:
       print "You missed my battleship."
board[guess_row][guess_col] = "X"

#2

here:

elif (board[guess_row][guess_col] == "X")

parentheses are not needed, and a colon is missing at the end. (if, elif, else should always have colons at the end)

your code can still given an index error:

board[guess_row][guess_col] = "X"

can be reached even when first if condition is true, indent the code that update the board so its nested inside the else which prints: you missed my battleship


#3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.