Not Again! IndexError?


#1

Hi, I am having trouble with this one when I enter my code. When I hit submit and then enter my guess for row and column, it shows this error: Traceback (most recent call last):
File "python", line 39, in
IndexError: string index out of range

This is my code:

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
else:
print "You missed my battleship!"
board[guess_row] = "X"
board[guess_col] = "X"
print_board(board)
if guess_row not in range(5) or \
guess_col not in range(5):
print "Oops, that's not even in the ocean."
elif board[guess_row][guess_col] == "X":
print "You guessed that one already."
else:
print "You missed my battleship!"

I don't understand what I did wrong so please help! :frowning:

`


#2

The test for range needs to follow directly after the win condition.


#3

Ah okay I did that and now my code looks like this:

from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

if guess_row == ship_row and guess_col == ship_col:
print "Congratulations! You sank my battleship!"
if guess_row not in range(5) or \
guess_col not in range(5):
print "Oops, that's not even in the ocean."
else:
print "You missed my battleship!"
board[guess_row] = "X"
board[guess_col] = "X"
print_board(board)
elif board[guess_row][guess_col] == "X":
print "You guessed that one already."
else:
print "You missed my battleship!"

But now it says invalid syntax for the elif statement. Did I write the elif statement correctly and is it in the right place? Where is it supposed to be in this case?


#4

Check your structure against the instructions. else cannot come before elif in the same block level.

if
elif
...
else

#5

Ahh okay thank you that fixed the problem!


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.