Not Again! don't know the problem with my elif statement


#1
from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col


if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
print_board(board)
    elif board[guess_row][guess_col] == "X":
        print "You Guessed that one already"

#2

elseif comes before else, and your print_board(board) needs to be indented


#3

Please copy paste the code and show me how it should look.


#4
from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif board[guess_row][guess_col] == "X":
     print "You Guessed that one already"
else:
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print_board(board)

I indented but giving me new error. Oops, try again. Did you remember to add the "You guessed that one already." message in your elif statement?


#5

That's not the point and think its against community rules to post solution. Try to swap your elseif and else


#6

Okay will try the swap. instead of solution can you please show me a bit of code using else and elif statements.


#7

oh I'm so bad at explaining. Your first if is good, put else after it and all code below put in that else

if condition is met:
    do this
else:
    if condition is met:
        do this
    elif condition is met:
        do this
    else:

#8

Thank you very much! Funniest thing happened though after doing the elseif swap the only problem was a typo in my print statement!:joy:


#10

You need to add "." to end the String like this:
print "You guessed that one already."


#11

Yea I finally got it to work. Thanks though!