Not again! Battleship!


#1



https://www.codecademy.com/en/courses/python-beginner-en-4XuFm/1/4?curriculum_id=4f89dab3d788890003000096#


The code works and allows me to move onto the next exercise, however, when I guess the same row and column twice it does not tell print "you guessed that one already."


from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

#print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:")) 
guess_col = int(raw_input("Guess Col:")) 

#print ship_row
#print ship_col
#The above statements show where the battleship was placed 
# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) or \
    guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    elif board[guess_row][guess_col]=="X":
        print "You guessed that one already."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col]="X"
    print print_board(board)


#2

sorry I just wondering
what specify number u put in after u press "sumit and save"


#3

Hi and thank you for responding!

I have since changed the ship row and ship col to standard values rather than being random integers so the game doesn't constantly change the ship location. I thought that would fix the problem but when I enter the same guess multiple times I never get the message "Oops you already guessed that."

for example, the ship location could be set such that ship_col== 2 and ship_row==4

however if I guess 1 for ship col and 3 for ship row multiple times it will just always tell me "You missed my battleship!" rather than giving me a message that says I already guessed that.


#4

Okay so I managed to solve this (as for if it is correct or not I do not know but the code works xD).

I essentially made the following into comments:

board = []

for x in range(0, 5):

#board.append(["O"] * 5)

and i put in non random values for the ship coordinates:

def random_row(board):
return 2

def random_col(board):
return 4

Doing this fixed my code.


#5

thank you!!! it reall heps


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.