Need Help! Unexpected keyword "else"


#1



https://www.codecademy.com/en/courses/javascript-beginner-en-Bthev-mskY8/1/3?curriculum_id=506324b3a7dffd00020bf661#


I keep getting an unexpected keyword "else" error but i can't seem to find the problem, can't tell if I'm over thinking or doing something wrong. (Beginner so probably the second one :joy:)


/*var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
	computerChoice = "rock";
} else if(computerChoice <= 0.67) {
	computerChoice = "paper";
} else {
	computerChoice = "scissors";
} console.log("Computer: " + computerChoice);*/

var compare = function(choice1, choice2){

if(choice1 === choice2) {
    return "The result is a tie!";
    }
    
    
    else if(choice1 === "rock")      {
         if (choice2 === "scissors") {
            return "rock wins"};
    }else{
        return "paper wins";
        }
}
    else if (choice1 === "paper") {
          if(choice2 === "rock")  { 
            return "paper wins"; 
    
        }else{
            return "scissors wins"}
    }


#2

@dhanadabanana

Problem seems to be coming from here:

Watch out for too many curly brackets like remove the one after string rock wins this should work.


#3

Thanks For the quick response!. Removing the extra curly bracket now leads me to another error - "unexpected end of script"


#4

Never mind i just released i forgot a curly bracket at the end of the script :joy:


#5

this is what your code seem to be

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice < 0.34) {
computerChoice = "rock";
} else if(computerChoice <= 0.67) {
computerChoice = "paper";
} else {
computerChoice = "scissors";
} console.log("Computer: " + computerChoice);

var compare = function(choice1, choice2){

if(choice1 === choice2) {
return "The result is a tie!";
}

else if(choice1 === "rock")      {
     if (choice2 === "scissors") {
        return "rock wins";
        }else{
    return "paper wins";
    }
}
else if (choice1 === "paper") {
      if(choice2 === "rock")  { 
        return "paper wins"; 

    }else{
        return "scissors wins";
        }
} else if(choice1==="scissors"){
    if(choice2==="rock"){
        return"rock win";
    }else{
        return "scissors win";
    }
}

};
compare(userChoice,computerChoice);


#6

Thank you so much, I literally was stuck on getting the compare part at the end to work!