Mixed Messages - Quotes & Jokes

Hello all !

Here’s my mixed messages project repo :

  • to run it, download the zip & open ‘index.html’

  • Your review of the Project. Was it easy, difficult, just right?
    • For the unit final, it was not quite as challenging as I was expecting (some object implementation would have been great!). Probably not a project I would include on my portfolio
  • An estimate of how long it took you to complete
    • about 2 hours

Any code reviews and/or suggestions are more than welcome. cheers!~


First, you have a very detailed README file. It is great!

And some thoughts and advices:

  1. As your first “optional stuff” says, you need to provide html form to access your app.
  2. Or you can provide a way to exit endless loop. For example, when user enters “Bye” as answer.
  3. Endless loop using for is confusing. Try to use while.
  4. Try to avoid global variables: declare variables in functions and use return values. If you need to return multiple values you can use array or object.

Good work!

PS Sorry for my English)

Hey thanks for the tips @9509706156, completely agree, these variables don’t need global scope, and a while(true) { } would look much cleaner.