Mixed Messages: Please could I have feedback?

Projects Portfolio Project: Mixed Messages
1

I decided to do a random Football Transfer.

Code:
const fantasyTransfers = {
playerNames: [‘Lional Messi’, ‘Cristiao Ronaldo’, ‘Neymar Jr.’, ‘Robert Lewandowski’, ‘Karim Benzema’, ‘Gerard Moreno’, ‘Jadon Sancho’, ‘Toni Kroos’, ‘Thiago Silva’, ‘Antoine Griezmann’, ‘Rodri’, ‘Joao Cancelo’, ‘John Stones’, ‘Kevin De Bruyne’, ‘Ruben Dias’, ‘Andre Silva’, ‘Nico Elvedi’, ‘Jordi Alba’, ‘Ilkay Gundogan’, ‘Diogo Jota’],
clubs: [‘Real Madrid’, ‘Barcelona’, ‘Ajax’, ‘Porto’, ‘Juventus’, ‘Inter Milan’, ‘AC Milan’, ‘Manchester United’, ‘Manchester City’, ‘Chelsea’, ‘Sporting Lisbon’, ‘PSV Eindhoven’, ‘Bayern Munich’, ‘Paris Saint-Germain’, ‘Borussia Dortmund’, ‘Liverpool’, ‘Tottenham’, ‘Athltico Madrid’, ‘Lyon’, ‘Napoli’],
value: [‘15 Million’, ‘20 Million’, ‘30 Million’, ‘40 Million’, ‘50 Million’, ‘60 Million’, ‘70 Million’, ‘80 Million’, ‘90 Million’, ‘100 Million’, ‘110 Million’, ‘120 Million’, ‘130 Million’, ‘140 Million’, ‘150 Million’, ‘160 Million’, ‘170 Million’, ‘180 Million’, ‘190 Million’, ‘200 Million’],
};

const randomTransfer = () => {
let playerNames = Math.floor(Math.random() * fantasyTransfers.playerNames.length);
let clubs = Math.floor(Math.random() * fantasyTransfers.clubs.length);
let value = Math.floor(Math.random() * fantasyTransfers.value.length);
console.log(${fantasyTransfer.clubs[clubs]} have signed ${fantasyTransfers.playerNames[playerNames]} for a fee of ${fantasyTransfers.value[value]}.);
};

randomTransfer();

2

Hi welcome to the forums :slight_smile:

The logic seems to work, the only thing is that your randomTransfer at the moment is a self-contained function (i.e. it doesn’t change anything). It would be neat if you had variables that tracked what the random transfer did outside of the function. So every time you run the function, the total amounts of changes would be tracked.

For future reference know that code should be formatted (for legibility and because it’s incredibly difficult to analyze otherwise): [How to] Format code in posts - #2