Mixed messages: Be Inspired! (Keeping it simple :-) )

dami-moore · July 10, 2021, 10:37am

Dami-Moore/mixed_messages_project/blob/master/mixed-messages.js

const randomNumber = Math.floor(Math.random() * 4);

const inspire = [
    "You're more than enough", 
    "You're unique, different and special. Nothing's wrong with you",
    "You're the best version of you! Be you!!",
    "You're a good person. Don't ever think otherwise."
];

const mixedMessages = () => {
switch (randomNumber) {
    case 0:
      console.log(inspire[0]);
      break;
    case 1:
      console.log(inspire[1]);
      break;
    case 2:
      console.log(inspire[2]);
      break;

This file has been truncated. show original

This is what I came up with. I’d love your feedbacks.

bcoding21 · July 10, 2021, 11:17am

Hi,

Looks good!

I think the switch conditional may be unnecessary.
Whilst it works, you can use a lot fewer lines to represent it. Dropping the switch will also improve performance (but it probably won’t be noticeable in this example).

You could simply use console.log():

const mixedMessages = () => {
    console.log(inspire[randomNumber]);
}

Hope that Helps!

micro9643173686 · July 10, 2021, 12:18pm

Hi there!
I too am just completing this project. Very relieved to see yours looks very similar to mine! This looks good. I am a novice working my way through the course and its’ great to see other work. Still trying to work out how to add my work on here and GitHub but getting there. Best wishes with your course!

Drea

bcoding21 · July 10, 2021, 12:27pm

Hi,

You can add code to the forum by using either of the two options in the editor:

Codebytes are useful if you would like others to be able to run the code within the forum.

Both Codecademy and GitHub have great articles on how to upload code to GitHub.

Hope that helps

micro9643173686 · July 10, 2021, 12:31pm

Hey there!

Thank you so much for this!

x

dami-moore · July 14, 2021, 12:11am

Awesome. Thanks a lot!!

avdleest · July 21, 2021, 4:18pm

Hi Sam!

Another improvement might be to make the randomNumber dependent on the array length, like this:

const randomNumber = Math.floor(Math.random() * inspire.length)

That way your script is independent of the length of the inspire array. Together with the comment of @bcoding21 this makes the script more versatile

dami-moore · July 21, 2021, 8:32pm

I really love this comment. I learnt how that others reviewing your work is also an opportunity to learn. This was really an eye opener!

avdleest · July 21, 2021, 9:20pm

My pleasure Thanks for your reply. I actually uploaded my version of the mixed messages project to GitHub as well. Check it out, it takes quite a different approach but might be interesting as well!

alin.bloj · April 9, 2024, 12:54pm

hi, this is my end result of the mixed messages project:

https://github.com/AlinBloj/mixed_messages

looking forward for any feedback
thanks

alin.bloj · April 9, 2024, 4:04pm

I like your approach