Mixed meessage _ Steve Jobs Quotes

yasirchowdhrey252599 · February 6, 2021, 1:24am

It was slightly challenging for me as I have been doing most exercises in codecademy terminal.
It took me 6 hours but majority to create the modal. The project is simple overall.
The link to your code repo
GitHub - ychowdhrey/codecademy_MM: Codecademy Mixed message project

I like the project and I was able to learn quite a few things. Suggestions are welcome.

jennyseal · February 6, 2021, 8:14pm

Nice. Good to practice the HTML and CSS too.

In the JS in my humble opinion I would probably change:
let index = Math.floor(Math.random() * 7);
to
let index = Math.floor(Math.random() * stevejobs.length);
Just so you only need to change one thing if you add in more quotes.

Also maybe instead of innerHTML use textContent, as it is more secure.

yasirchowdhrey252599 · February 7, 2021, 1:19am

Hey,

Thanks for the input, yes should have stevejobs.lenght.
Will update it today.

Okay not familiar with textContent, let me read about it. Got hooked to innerHTML from W3school tutorial.

Thanks again for the suggestion. All the best.

tomjmartinez · February 10, 2021, 3:27pm

hey, great job incorporating the script into html.

And even though you decided to not mix and match from 3 sets of strings as indicated in the project instructions, I love the fact that you did something more inspirational by using “steve jobs lives on” quotes ha