Magic Eight ball Help

[midlindner]

console.log(greeting(userName));

In this statement you call the greeting function. The function prints the greeting as specified inside of its code body. Since you don’t have a return statement in the function, the function implicitly returns 'undefined' to the caller. In this case the caller is console.log(), so 'undefined' gets logged to the console after your greeting. To fix this behavior you can do one of two things. Either change your console.log() statements inside your function to return the greeting, or just invoke the function without the console.log() like so: greeting(userName).

let userName = 'Joe';
function greeting (userName){
  if(userName !== ''){
    console.log('Hello '+ userName + '!'); //change console.log to: return
  } else {
    console.log('Hello!') //same thing here
  }
};
console.log(greeting(userName)); //Or change to: greeting(userName);

[hromodealba]

Thanks! I just fixed it

[jeve94]

Hello! Struggled through this and got this as my answer but the code won’t run. Can anyone tell me where i’ve gone wrong?

let userName = 'Jess';
userName ? console.log(`Hello, ${userName}!`): console.log('Hello!');

let userQuestion = 'Will I ever learn JavaScript?';
console.log(`${userName} asked: ${userQuestion}`);

let randomNumber = Math.floor(Math.random()*8);

let eightBall ='';

if (randomNumber === 0){
  eightBall = 'It is certain';
} else if (randomNumber === 1){
  eightBall = 'It is decidedly so';
} else if (randomNumber === 2){
  eightBall = 'Reply hazy try again';
} else if (randomNumber === 3){
  eightBall = 'Cannot predict now';
} else if (randomNumber === 4){
  eightBall = 'Do not count on it';
} else if (randomNumber === 5){
  eightBall = 'My sources say no';
} else if (randomNumber === 6){
  eightBall = 'Outlook not so good';
} else (randomNumber === 7){
  eightBall = 'Signs point to yes';
}

console.log(`${eightBall}`);

[midlindner]

} else (randomNumber === 7){ //remove the parenthesis and everything inside them
  eightBall = 'Signs point to yes'; 
 }

This is the only thing preventing your code from running. The else code block executes as a default if no prior if or else if conditions are truthy. You cannot test a condition in your else block. If randomNumber != to 0 through 6 the only other possible value is 7. Happy Coding!

[simonluca]

Hi there! i managed to make the control flow work with the switch statements but when I use the if / else if the eight ball answer comes before the string:

Hello Martina!
The user asked
Cannot predict now
The eight ball answered:

Here’s my code:

let randomNumber = Math.floor(Math.random()*8);

let eightBall = ''; 

if (randomNumber === 0) {
  console.log('It is certain');
}
else if (randomNumber === 1) {
  console.log('It is decidedly so');
}
else if (randomNumber === 2) {
  console.log('Reply Hazy try again');
}
else if (randomNumber === 3) {
  console.log('Cannot predict now');
}
else if (randomNumber === 4) {
  console.log('Do not count on it');
}
else if (randomNumber === 5) {
  console.log('My sources say no');
}
else if (randomNumber === 6) {
  console.log('Outlook not so good');
}
else if (randomNumber === 7) {
  console.log('Signs point to yes');
  
  
}

console.log(`The eight ball answered: ${eightBall}`);

Not sure what I’m doing wrong??

[midlindner]

let eightBall = '';
  if (randomNumber === 0) {
    console.log('It is certain'); 
  } 

In your code, you declaring eightBall as an empty string. When you determine what the answer will be with your if…else if statements, you are logging the answer to the console. This happens before your

console.log(`The eight ball answered: ${eightBall}`);

statement. When this statement finally executes, eightBall is still empty. If you change console.log('answer'); to eightBall = 'answer'; you will get the outcome you were expecting.
Also, just a side note, your final else if only needs to be an else with no condition to test. If random number wasn’t 0 - 6, 7 is the only value remaining that it could be, so else will suffice.
Happy coding!

[tagwhiz55588]

This worked for me on Step 9.

• If you started with a switch statement, convert it to if/else if/else statements. -

I tried over and over again and finally used the ==.
Here’s my code below!

let userName = ‘Nancy’;

userName ? console.log(Hello ${userName}!) : console.log(‘Hello!’);

const userQuestion = ‘Will I become a mermaid this summer?’;
console.log(The user asked: ${userQuestion});
const randomNumber = Math.floor(Math.random() * 8);
let eightBall = ‘’;

if (randomNumber == 0) {
console.log(‘The eight ball answered: It is certain’);
} else if (randomNumber == 1) {
console.log(‘The eight ball answered: It is decidedly so’);
} else if (randomNumber == 2) {
console.log(‘The eight ball answered: Reply hazy try again’);
} else if (randomNumber == 3) {
console.log(‘The eight ball answered: Cannot predict now’);
} else if (randomNumber == 4) {
console.log(‘The eight ball answered: Do not count on it’);
} else if (randomNumber == 5) {
console.log(‘The eight ball answered: My sources say no’);
} else if (randomNumber === 6) {
console.log(‘The eight ball answered: Outlook not so good’);
} else if (randomNumber == 7) {
console.log(‘The eight ball answered: Signs point to yes’);
} else {
console.log(‘The eight ball is broken’)
};

[will_hm]

So the code works perfectly without

let eightBall = '';

Can you tell me why the exercise called for this in the first place?

[midlindner]

What code works perfectly without let eightBall = '';? Could you share the code in question? The declaration of the variable eightBall has a specific purpose the way it is used in the lesson. If you are using either a switch ... case block, or an if ... else if ... else block to assign a value to eightBall like so; eightBall = 'It is decidedly so.', without the aforementioned variable declaration, you end up declaring eightBall as a global variable at the time of assignment. In a small project like this, there is little to no consequence, but it is very bad practice to give any variable scope beyond it’s needs. It can lead to many problems in a large more complicated project. By using let eightBall = '' prior to assigning a value later, you are limiting the scope to the block of code in which it was declared including any nested code blocks.

[will_hm]

The code that user factoradic posted. Here’s mine for good measure.

let userName = 'Buzz';

userName ? console.log(`Hello, ${userName}!`) : console.log('Hello!');

let userQuestion = 'Will I ever return to the moon?';

console.log(`${userQuestion}`);

const randomNumber = Math.floor(Math.random() * 8);

switch (randomNumber) {
  case 0:
    eightBall = 'It is certain'
    break;
  case 1:
    eightBall = 'It is decidedly so'
    break;
  case 2:
    eightBall = 'Reply hazy try again'
    break;
  case 3:
   eightBall = 'Cannot predict now'
    break;
  case 4:
    eightBall = 'Do not count on it'
    break;
  case 5:
    eightBall = 'My sources say no'
    break;
  case 6:
    eightBall = 'Outlook not so good'
    break;
  case 7:
    eightBall = 'Signs point to yes'
    break;
}

console.log(`The eight ball answered:
${eightBall}`);

Your point on the global scope of eightBall is well taken, thank you. I understand why the exercise didn’t want to overload us with concepts we may not be familiar with yet, but it’s still good to know why a piece of code is necessary.

[nastya_nmk]

I thought that if we wanted to always print our ‘Hello, Jane!’, it was needed to use: var userName = '' userName ? console.log('Hello, Jane!') : console.log('Hello!');

instead of : 'Jane' ? console.log('Hello, Jane!') : console.log('Hello!');

[factoradic]

'' ? console.log('Hello, Jane!') : console.log('Hello!');
// Hello! <- because empty string is considered false

'Jane' ? console.log('Hello, Jane!') : console.log('Hello!');
// Hello, Jane! <- because 'Jane' is non-empty string

What is your question?

[joshuahizgiaev734425]

https://gist.github.com/codecademydev/ffc15f20aacef9851a31c2d6a6173dcc

Here is my JAVA solution, I decided to make it much more complex and feel like an actual eight ball rather than it just doing 1 function once. If you are confused please reply to this post, If you are wondering why nothing is in the constructor that is because nothing needs to be as I utilized scanner which takes in user input as well as Thread.sleep which ill be happy to explain you ask. I didnt do this in the codeacademy code editor btw I used eclipse IDE. I HIGHLY recommend running the program to see how it works. Thank you. Also when you are running it, yes there is only 2 outcomes but I was just too lazy to put in more, you can always edit and put your own outcomes in the String array “ballOutcomes” as well as changing how many numbers that can be randomly generated in the getRandomNumbers method. If you are wondering why if you type in the same question and get a different outcome, that is just how magic 8 balls work :P.

[bit5522376907]

Hi,
What about this solution? It is different but it still works:

let userName = "";
userName ? console.log(`Hello ${userName}`) : console.log('Hello!');

let userQuestion ="Will I be a celebrity?";
console.log(`The user asked: ${userQuestion}`);
  
let randomNumber = Math.floor(Math.random() * 8);

const eightBall = randomNumber;

switch (eightBall) {
  case 0:
  console.log('It is certain');
  break;
  case 1:
  console.log('It is decidedly so');
  break;
  case 2:
  console.log('Reply hazy try again');
  break;
  case 3:
  console.log('Cannot predict now');
  break;
  case 4:
  console.log('Do not count on it');
  break;
  case 5:
  console.log('My sources say no');
  break;
  case 6:
  console.log('It is certain');
  break;
  case 7:
  console.log('Outlook not so good');
  break;
  case 8:
  console.log('No way');
  break;
}

[amitsisodia]

The below code is the code created per the instructions, and works perfectly fine:

let userName = ‘’;
userName ? console.log(Hello, ${userName}!) : console.log(‘Hello!’);

const userQuestion = ‘Will I become the Software Engineer within this year?’;
console.log(You\'ve asked: ${userQuestion});

const randomNumber = Math.floor(Math.random() * 8);

let eightBall = ‘’;
console.log(The eight ball answered: ${eightBall});

switch (randomNumber) {
case 0:
console.log(It is certain.);
break;
case 1:
console.log(It is decidedly so.);
break;
case 2:
console.log(Reply hazy try again.);
break;
case 3:
console.log(Cannot predict now.);
break;
case 4:
console.log(Do not count on it.);
break;
case 5:
console.log(My sources say no.);
break;
case 6:
console.log(Outlook not so good.);
break;
case 7:
console.log(Signs point to yes.);
break;
}

console.log(eightBall);

[letronique]

The question is that

'' ? console.log('Hello, Jane!') : console.log('Hello!');

makes no sense because anyone who adds a string would be called Jane! So how is this meant to be written?

The answer is Template Literals.

userName ? console.log(`Hello, ${userName} !`) : console.log('Hello!');

[andre_moguel]

const userName = ''
userName ? console.log(`Hello ${userName}`) : console.log('Hello');


const userQuestion = 'Will I become a werewolf tonight?';
console.log(`The user ${userName} asked : ${userQuestion}`);

let randomNumber = Math.floor(Math.random() * 8);

let eightBall = ''


switch (randomNumber) {
  case 0: 
  eightBall = 'It is certain';
  break;
  case 1:
  eightBall = 'It is decidedly so';
  break;
  case 2: 
  eightBall = 'Reply hazy try again';
  break;
  case 3:
  eightBall = 'Cannot predict now';
  break;
  case 4:
  eightBall = 'Do not count on it';
  break;
  case 5:
  eightBall = 'My sources say no';
  break;
  case 6:
  eightBall = 'Outlook not so good';
  break;
  case 7:
  eightBall = 'Signs point to yes';
  }

  console.log(`The eight ball answered: ${eightBall}`);

this is how i wrote mine and it seem to work

[midlindner]

Nice work.

Consider:

console.log(userName ? `Hello ${userName}` : `Hello`);

or

const userName = 'Herbert';
console.log(`Hello${userName ? `, ${userName}` : ''}!`);

Output:

Hello, Herbert!

without a name:

const userName = '';
console.log(`Hello${userName ? `, ${userName}` : ''}!`);

Output:

Hello!

[rocketman788]

console.log(`The user ased: \'${userQuestion}\'`)

const randomNumber = Math.floor(Math.random * 8)

let eightBall = 'none';

switch (randomNumber) {
  case 0:
    eightBall = 'It is certain';
    break;
  case 1:
    eightBall = 'It is decidedly so';
    break;
  case 2:
    eightBall = 'Reply hazy try again';
    break;
  case 3:
    eightBall = 'Cannot predict now';
    break;
  case 4:
    eightBall = 'Do not count on it';
    break;
  case 5:
    eightBall = 'My sources say no';
    break;
  case 6:
    eightBall = 'Outlook not so good';
    break;
  case 7:
    eightBall = 'Signs point to yes';
    break;
}

console.log(eightBall)

the value of eightBall doesn’t change so I end up with an empty string instead of an eightBall reply

[rocketman788]

I got it
I used Math.random instead of Math.random()