It passes but its messed up


#1
from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)
    
ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row==ship_row and guess_col==ship_col:
    print"Congratulations! You sank my battleship!"
else:
     board[guess_row][guess_col] = 'X'
print_board(board)
print "You missed my battleship!"
if guess_row not in range(5) or \
   guess_col not in range(5):
       print "Oops, that's not even in the ocean."
elif guess_row=='X' or guess_col=='X':
    print "You guessed that one already."
else:
        board[guess_row][guess_col] == 'X'
print_board(board)
print "You missed my battleship!"

#2

Should be like this:

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif guess_row not in range(5) or \
       guess_col not in range(5):
           print "Oops, that's not even in the ocean."
elif board[guess_row][guess_col] == "X":
    print "You guessed that one already."
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"

You just have some duplicated code that's all.


#3
if guess_row not in range(5) or guess_col not in range(5):

This line seems to be giving us some trouble. I cannot get it to work. What works for me is this,

if guess_row < 0 or guess_row > 4 or guess_col < 0 or guess_col > 4:

We will need to wait for a Python aficionado to weigh in on this question.


#4

fixed it! thanks so much


#6

Just type in the Error. Is it an exercise dependent error or an error displayed in the console output?


#7

There was no reported error, it just didn't work as expected. Must have been my code.

Your code makes sense. My code is (was),

else:
    if ...

Thanks for the clarification. After the repairs everything is working as expected, now.