Invalid Syntax - Play it Sam


#1

<Below this line, add a link to the EXACT exercise that you are stuck at.>
https://www.codecademy.com/courses/learn-python/lessons/battleship/exercises/play-it-sam?action=lesson_resume&link_content_target=interstitial_lesson

<In what way does your code behave incorrectly? Include ALL error messages.>
I cannot see what is wrong with my syntax here.
File “python”, line 37
elif (board[guess_row][guess_col] == “X”):
^
SyntaxError: invalid syntax

<What do you expect to happen instead?>
run normally

```python
from random import randint

board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)

print_board(board)

def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should be in your for loop
# don't forget to properly indent!
for turn in range(4):
	guess_row = int(raw_input("Guess Row: "))
	guess_col = int(raw_input("Guess Col: "))

	if guess_row == ship_row and guess_col == ship_col:
  		print "Congratulations! You sank my battleship!"   
	else:
  		if guess_row not in range(5) or \
    guess_col not in range(5):
    			print "Oops, that's not even in the ocean."
  	elif (board[guess_row][guess_col] == "X"):
    	print( "You guessed that one already." )
  	else:
    	print "You missed my battleship!"
    	board[guess_row][guess_col] = "X"
  print_board(board)
  # print turn + 1 here
print "Turn",turn + 1
<do not remove the three backticks above>

#2

you can have an elif after an else, the order is always:

if
elif
else

i think you need to look at your indent, the if not in range, elif already guessed and else you missed should have the same indent level


#3

Thanks, seemed like it was an indentation error. changing it to

for turn in range(4):
	guess_row = int(raw_input("Guess Row: "))
	guess_col = int(raw_input("Guess Col: "))

	if guess_row == ship_row and guess_col == ship_col:
  		print "Congratulations! You sank my battleship!"   
	else:
  		if guess_row not in range(5) or guess_col not in range(5):
    			print "Oops, that's not even in the ocean."
  		elif (board[guess_row][guess_col] == "X"):
    			print( "You guessed that one already." )
  		else:
   		 	print "You missed my battleship!"
    		board[guess_row][guess_col] = "X"
  	print_board(board)
  # print turn + 1 here
	print "Turn",turn + 1

got it working perfectly


#4

seems you got it :slight_smile:

so we have if an else to determine hit and miss:

	if guess_row == ship_row and guess_col == ship_col:
  		print "Congratulations! You sank my battleship!"   
	else:
                # handle different misses here

then we have an if, elif and else to handle the different scenarios for missing, its also important to understand design of this program


#6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.