I am confusion. Eggsblain, What do you mean by "Oops, that's not even in the ocean"?


#1

https://www.codecademy.com/courses/learn-python/lessons/battleship/exercises/bad-aim?action=lesson_resume

from random import randint

board = []

for x in range(0, 5):
  board.append(["O"] * 5)

def print_board(board):
  for row in board:
    print " ".join(row)

print_board(board)

def random_row(board):
  return randint(0, len(board) - 1)

def random_col(board):
  return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col
guess_row = int(raw_input("Guess Row: "))
guess_col = int(raw_input("Guess Col: "))

if guess_row == ship_row and guess_col == ship_col:
  print "Congratulations! You sank my battleship!" 
elif board[guess_row][guess_col] == "X":
  print "You guessed that one already"
else:
  if guess_row != range(5) or guess_col != range(5):
    print "Oops, that's not even in the ocean."
  else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

O O O O O
O O O O O
O O O O O
O O O O O
O O O O O
2
0
Guess Row: 1
Guess Col: 2
Oops, that's not even in the ocean.

How come I get “Oops, that’s not even in the ocean.” ? Clearly 1 and 2 is still within range(5). I expected it to print “You missed my battleship!”. What could be the error here. Can someone please help me??


#2

range() produces a list, and guess_row (and guess_col) are integers. The will never equal, so guess_row != range(5) is always true


#3

OK so if I replaced the one above with this

  if guess_row not in range(5) or \
  guess_col not in range(5):
    print "Oops, that's not even in the ocean."
  elif board[guess_row][guess_col] == "X":
    print "You guessed that already."
  else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

it seemed to solve the problem.

I get this

O O O O O
O O O O O
O O O O O
O O O O O
3
0
Guess Row: 2
Guess Col: 1
You missed my battleship!
O O O O O
O O O O O
O X O O O
O O O O O
O O O O O

I am still confusion, Eggsblain ples,


#4

Eggsblain, you mean: explain?

Still confused about what?


#5

Ohhhhh I see. Thank you very much.


#6

I understand the issue now :slight_smile:


#7