Help with 'not again'


#1

hi, this is my current code - thought i was on track - but obviously not:

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print "Lets play"
print ship_row
print ship_col

if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
else:
    if guess_row not in range(5) or \
    guess_col not in range(5):
        print "Oops, that's not even in the ocean."
        elif board [guess_row][guess_col] == "X":
            print "You guessed that one already."
    else:
        print "You missed my battleship!"
    board [guess_row][guess_col] = "X"
    print_board(board)

where did i go wrong?


#2

Take a step back and study the scenarios:

  1. win
  2. not in range
  3. guessed already
  4. missed

if 

elif

elif

else

#3


else:
if guess_row not in range(5) or \
guess_col not in range(5):
print "Oops, that's not even in the ocean."
elif board [guess_row][guess_col] == "X":
print "You guessed that one already."

Consider reviewing your indentation in this block. The elif statement shouldn't be nested within the "if guess_row.."


#4

Hi there folks.

What do you think is wrong with the code below?


from random import randint

board = []

for x in range(0, 5):
board.append(["O"] * 5)

def print_board(board):
for row in board:
print " ".join(row)

print_board(board)

def random_row(board):
return randint(0, len(board) - 1)

def random_col(board):
return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

Write your code below!

board_guess = board[guess_row][guess_col]

if guess_row == ship_row and guess_col == ship_col:
print("Congratulations! You sank my battleship!")
elif board_guess == "X":
Print("You guessed that one already!"
else:
print("You missed my battleship!")
board[guess_row][guess_col] = "X"
print_board(board)

if guess_row not in range(5) \
or guess_col not in range(5):
print("Oops, that's not even in the ocean.")
else:
print("You missed my battleship!")
board_guess = "X"
print_board(board)


#5

Javarunner, what is the error message that you are getting? Also, could you repost your code using the preformatted text feature ()? Without the indentations, it's hard to see if/where there is an error


#6

This should be just after "You sank my battleship!" as an elif


#7

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
board_guess = board[guess_row][guess_col]

if guess_row == ship_row and guess_col == ship_col:
    print("Congratulations! You sank my battleship!")
    if guess_row not in range(5) \
    or guess_col not in range(5):
        print("Oops, that's not even in the ocean.")
elif board_guess == "X":
    Print("You guessed that one already!"
elif not guess_row == ship_row and guess_col == ship_col:
    print("You missed my battleship!")
    board[guess_row][guess_col] = "X"
    print_board(board)


else:
    print("You missed my battleship!")
    board_guess = "X"
    print_board(board)

The error message : File "python", line 38
elif not guess_row == ship_row and guess_col == ship_col:
^
SyntaxError: invalid syntax


#8

Unindent this and make it an elif


#10

Hey buddy. It's not working again.


#11

print can not be capitalized. That's the actual error.


#12

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.