Guess Out of Range handler help (14. Test Run)


#1



https://www.codecademy.com/courses/python-beginner-en-4XuFm/1/5?curriculum_id=4f89dab3d788890003000096


I am test running the game and I am testing to see what happens when a player inserts a guess that is outside the 5x5 range.
I managed to pass the step that actually checks if I have put in the handler for this case, so I can technically move on.
However, when I enter a guess that is outside the range, the console does not print "Oops that's not even in the ocean."
Instead it gives this error message:

Traceback (most recent call last):
File "python", line 35, in
IndexError: list index out of range

Is this supposed to happen or is there something wrong with my code??

Thanks for the help! :slight_smile:


Here's my complete code

from random import randint

board = []

for x in range(0, 5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print_board(board)

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
guess_row = int(raw_input("Guess Row:"))
guess_col = int(raw_input("Guess Col:"))

print ship_row
print ship_col

# Write your code below!
if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif guess_row == "X" and guess_col == "X":
    print "You guessed that one already."
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print_board(board)


#2

@narusteph
You have a few errors in your code.

The first is in your original else statement:


else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)
    if guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
    else:
        print "You missed my battleship!"
        board[guess_row][guess_col] = "X"
        print_board(board)

In general you shouldn't have another if statement within an else statement. Instead you can create another elif statement within your if/elif/else statements like so:


if guess_row == ship_row and guess_col == ship_col:
    print "Congratulations! You sank my battleship!"
elif guess_row == "X" and guess_col == "X":
    print "You guessed that one already."
**elif** guess_row not in range(5) or guess_col not in range(5):
        print "Oops, that's not even in the ocean."
else:
    print "You missed my battleship!"
    board[guess_row][guess_col] = "X"
    print_board(board)

Finally, I'd suggest using this code instead of your previous to solve the problem of the list indices being out of range:


elif guess_row **> 5** or guess_col  **> 5**:
        print "Oops, that's not even in the ocean."

Hope this helped :slight_smile:


#3

Thanks a lot!

My code looks a lot better and the out-of-range problem is solved!


#4

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.