"Game Over" exercise in Battleship. Hope you can give me some advice!


Excuse me, I am stuck in this exercise. I know the code written by me doesn't meet the request but I have no idea about how to improve. I have read other's question but I more want to get some advice about my personal case.

Especially, when I guessed 4 times and don't guess the right position, my program couldn't print "Game Over". How can I rewrite my program?


from random import randint

board = []

for x in range(5):
    board.append(["O"] * 5)

def print_board(board):
    for row in board:
        print " ".join(row)

print "Let's play Battleship!"

def random_row(board):
    return randint(0, len(board) - 1)

def random_col(board):
    return randint(0, len(board[0]) - 1)

ship_row = random_row(board)
ship_col = random_col(board)
print ship_row
print ship_col

# Everything from here on should go in your for loop!
# Be sure to indent four spaces!
for turn in range(4):
    if turn < 4:
        guess_row = int(raw_input("Guess Row:"))
        guess_col = int(raw_input("Guess Col:"))
        if guess_row == ship_row and guess_col == ship_col:
            print "Congratulations! You sunk my battleship!"
            if (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4):
                print "Oops, that's not even in the ocean."
            elif(board[guess_row][guess_col] == "X"):
                print "You guessed that one already."
                print "You missed my battleship!"
                board[guess_row][guess_col] = "X"
        print "Turn", turn + 1
        if turn == 3:
            print "Game Over"


if the user succesfully guesses the ship, you don't want the loop to continue (given the user won), to achieve this we need to break the loop:

        if guess_row == ship_row and guess_col == ship_col:
            print "Congratulations! You sunk my battleship!"
            # the user won, break the loop
            # so he won't be prompted anymore, the game should end


Hi, @stetim94 , can you tell my how can I rewrite the program to print "Game Over" if I guessed 4 times and didn't guess right position? In my current program, it wouldn't do this work...


well, range() doesn't include its stop value, so the values produced by range are: 0, 1, 2 and 3

i would remove this:

if turn < 4:

and check if turn equals 3 after the user had a turn


This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.